Todo List

Member qgar::AbstractGraphicsFile::write (AbstractGenPointChain< int > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT)=0: Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Member qgar::AbstractGraphicsFile::write (AbstractGenPointChain< float > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT)=0: Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Member qgar::AbstractGraphicsFile::write (AbstractGenPointChain< double > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT)=0: Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Class qgxml::BinInputStreamAdaptor: Comment this class!

Member qgar::GenImage::copyBox (const GenImage< value_type, CheckPolicy > &anImg, unsigned int aXTopLeft, unsigned int aYTopLeft, unsigned int aXBottomRight, unsigned int aYBottomRight, value_type aPixVal=static_cast< value_type >(0)): To be reimplemented.

Class qgar::CloseBinaryImage: Allow the use of other structural elements, like disks or crosses.

Class qgar::ConnectedComponents: Give the user the choice between implementing components as labelled regions in an image (like now) and implementing components through tables of runs and labels (presently, these tables are deleted once components are constructed)

Class qgar::ConnectedComponents: qgar::ConnectedComponents::PRIVATEcopyCC perfoms a deep copy of a tree. This method should be moved to class qgar::GenTree.

Class qgar::ConnectedComponentsImpl: Give the user the choice between implementing components as labelled regions in an image (like now) and implementing components through tables of runs and labels (these tables are presently deleted once components are constructed)

Class qgar::Dist34Image

In the constructor code, use pixel map pointers instead of nested loops (for iCnt and for jCnt) to get less tests (and thus save time).
The constructor performs a copy of the given image: If it is a deep copy, is it really necessary?
The way the distance is computed is rather weird: See class qgar::Dist8cBlackCCImage for example!
Given binary image must exclusively contain 0's and 1's.

Class qgar::Dist8cBlackCCImage

In constructor code, use pixel map pointers instead of nested loops (for iCnt and for jCnt) to get less tests (and thus save time).
The constructor performs a copy of the given image: If it is a deep copy, is it really necessary?
Given binary image must exclusively contain 0's and 1's.

Class qgar::DxfFile

Member qgar::DxfFile::write (AbstractGenPointChain< int > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenPointChain modify data member qgar::GenPointChain::_iter, which should be declared as mutable.

Member qgar::DxfFile::write (AbstractGenPointChain< float > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenPointChain modify data member qgar::GenPointChain::_iter, which should be declared as mutable.

Member qgar::DxfFile::write (AbstractGenPointChain< double > &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenPointChain modify data member qgar::GenPointChain::_iter, which should be declared as mutable.

Member qgar::DxfFile::write (const ConnectedComponents::node_type *const aPNode, int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): Implement qgar::DxfFile::write(const qgar::ConnectedComponents::node_type* const, int, qgar::QGEcolor, qgar::QGEoutline)

Member qgar::DxfFile::write (const GenPoint< int > &aCenter, double aRadius, int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<int>&, double, int, qgar::QGEcolor, qgar::QGEoutline)

Member qgar::DxfFile::write (const GenPoint< float > &aCenter, double aRadius, int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<float>&, double, int, qgar::QGEcolor, qgar::QGEoutline)

Member qgar::DxfFile::write (const GenPoint< double > &aCenter, double aRadius, int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<double>&, double, int, qgar::QGEcolor, qgar::QGEoutline)

Member qgar::DxfFile::write (const GenPoint< int > &aPt, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<int>&, int, qgar::QGEcolor)

Member qgar::DxfFile::write (const GenPoint< float > &aPt, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<float>&, int, qgar::QGEcolor)

Member qgar::DxfFile::write (const GenPoint< double > &aPt, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Implement qgar::DxfFile::write(const qgar::GenPoint<double>&, int, qgar::QGEcolor)

Member qgar::GenArc::GenArc (): Such an arc does not conform the definition of an arc!

Class qgar::GenConvexHull< T >: Class to be completed: In particular, insertion and removal of points are not implemented.

Member qgar::GenEdge::GenEdge (const GenEdge< node_type, edge_type > &anEdge): This constructor performs a shallow copy. Could it perform a deep copy? Nodes adjacent to the edge would thus be copied, and then all edges adjacent to these nodes, and the nodes adjacent to these edges... and then the whole graph!...

Member qgar::GenEdge::operator= (const GenEdge< node_type, edge_type > &anEdge): This constructor performs a shallow copy. Could it perform a deep copy? Nodes adjacent to the edge would thus be copied, and then all edges adjacent to these nodes, and the nodes adjacent to these edges... and then the whole graph!...

Member qgar::GenImage::GenImage (AbstractPbmPlusFile &aPbmPlusFile): Constructor qgar::GenImage::GenImage(AbstractPbmPlusFile&) should just work when T is instantiated by an unsigned char because function qgar::AbstractPbmPlusFile::readRow only works with rows of unsigned integers whereas the first argument of function qgar::GenImage::setRow is a pointer to a row of type T!

Member qgar::GenNode::GenNode (const GenNode< node_type, edge_type > &aNode): This constructor performs a shallow copy. Could it perform a deep copy? Edges adjacent to the node would thus be copied, and then all nodes adjacent to these edges, and the edges adjacent to these nodes... and then the whole graph!

Member qgar::GenNode::operator= (const GenNode< node_type, edge_type > &aNode): This constructor performs a shallow copy. Could it perform a deep copy? Edges adjacent to the node would thus be copied, and then all nodes adjacent to these edges, and the edges adjacent to these nodes... and then the whole graph!

Member qgar::GenPointChain::pointList (): Maybe this kind of function should not be provided!

Member qgar::GenPolygon::GenPolygon (): The created polygon does not conform to the definition of a polygon: The vertices deque is empty whereas it should contain at least 3 elements!

Member qgar::GenPolyline::GenPolyline (): The created polyline does not conform to the definition of a polyline: The vertices deque is empty whereas it should contain at least 2 elements!

Member qgar::GenQgarArc::GenQgarArc (int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): The created arc does not conform to the definition of an arc!

Member qgar::GenQgarPolygon::GenQgarPolygon (int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): The vertices should at least be 3!

Member qgar::GenQgarPolyline::GenQgarPolyline (int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): The created polyline does not conform to the definition of a polyline: The vertices deque is empty whereas it should contain at least 2 elements!

Member qgar::GenQgarSegment::GenQgarSegment (int aThickness=1, QGEcolor aColor=QGE_COLOR_DEFAULT, QGEoutline anOutline=QGE_OUTLINE_DEFAULT): The created Qgar segment does not conform to the definition of a segment!

Member qgar::GenSegment::GenSegment (): The created segment does not conform to the definition of a segment!

Member qgar::GenSegment::contains (const GenPoint< T > &c, double aDist=MathepsilonD()): Use values computed for 'r' to get the distance between the point and the segment, instead of using function qgar::qgDist, which computes again these values.

Member qgar::GenUGraph::remove (typename nodes_list_type::iterator aPos)

Maybe the way adjacent edges of the nodes are deleted could be more efficient. In particular, the use of function qgar::GenUGraph::removeEdge implies:

a copy of the edges list of the current node,
an update of the edges list of the current node each time an edge is removed from the graph, whereas this edges list could be cleared in one time, once all edges are removed.

Member qgar::HysteresisBinaryImage::HysteresisBinaryImage (const GradientLocalMaxImage &aGradImg, unsigned int aLowThrsl, unsigned int aHighThrsl)

Look at lines like 'val == 0.0', where 'val' is a float!
Use pointers to pixel maps instead of nested loops to run through images.

Class qgar::KanungoBinaryImage: To be documented!...

Class qgar::LaplacianOfGaussianImage

Check the correctness of the constructor from a float image. It converts a float image to a greylevel image.
function qgar::LaplacianOfGaussianImage::PRIVATEbuildLOGImage returns a float image, which is then duplicated in constructors!

Class qgar::LinkedChainList: This class should not derive from STL class list, but should be its client! The current implementation may be/is the cause of memory losses due to the use of dynamically allocated objects by the function members...

Member qgar::LinkedChainList::LinkedChainList (unsigned int minChainLength=0, unsigned int minCycleLength=0)

Karl's note: For temporary use.
G!'s note: Make it actually temporary!

Class qgar::MapleFile: No function to read a Maple file (except MapleFile::readHeader, that is a pure virtual function and must be implemented).

Class qgar::OpenBinaryImage: Allow the use of other structural elements, like disks, crosses...

Class qgar::QgarApp: Complete and update documentation

Class qgar::QgarAppDescr: Insert a link to the document DTD.

Member qgar::QgarAppDescr::characters (const char *ch, const unsigned int start, const unsigned int length): To be documented!

Member qgar::QgarAppDescr::startElement (const std::string &uri, const std::string &localName, const std::string &qName, const qgxml::Attributes &atts): To be documented!

Member qgar::QgarAppDescr::endElement (const std::string &uri, const std::string &localName, const std::string &qName): To be documented!

Member qgar::QgarAppDescr::fatalError (const qgxml::SAXParseException &exception): To be documented!

Class qgar::QgarArgs::QgarParam: Complete the documentation

Class qgxml::QtQgarContentHandlerAdaptor: Comment this class!

Class qgxml::QtQgarDTDHandlerAdaptor: Comment this class!

Class qgxml::QtQgarEntityResolverAdaptor: Comment this class!

Class qgxml::QtQgarErrorHandlerAdaptor: Comment this class!

Class qgxml::QtQgarInputSourceAdaptor: Comment this class!

Class qgxml::QtStringConverter: Comment this class!

Class qgxml::QtXMLReaderAdaptor: Comment this class!

Class qgar::RWArcVector

Why ''Qgar arcs'' (from class qgar::GenQgarArc), instead of ''arcs'' (from class qgar::GenArc)?
Anyway, this class was designed when STL was not available. To be removed!

Class qgar::RWTree: Find an other solution than a private class!

Class qgxml::SAXException: Implement the embedded exception.

Member qgar::TgifFile::write (AbstChain &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Member qgar::TgifFile::write (FAbstChain &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Member qgar::TgifFile::write (DAbstChain &aChain, int aThickness=3, QGEcolor aColor=QGE_COLOR_DEFAULT): Parameter aChain cannot be declared const because functions qgar::AbstractGenPointChain::setToBegin and qgar::AbstractGenPointChain::moveNext are not declared const. In particular, their implementation in class qgar::GenLinkedChain modify data member qgar::GenLinkedChain::_iter, that should be declared as mutable.

Member qgar::TgifFile::saveChain (AbstractGenPointChain< T > &aChain, int aThickness, QGEcolor aColor): Argument aChain cannot be declared const because iterating on a list occasions some modifications in the list (see function setInitialPosition() of class qgar::GenChain, for example). Class AbstractGenPointChain and its descendants should be modified by declaring some data members as mutable.

Member qgar::TgifFile::readHeader (): Implement qgar::TgifFile::readHeader()

Class qgar::TTBinaryImage: Introduce BLACK and WHITE values as parameters of the computation of the connected components: In this way, there will be no need to duplicate an image if 4-connected black components are needed.

Class qgar::WDSegment: Dirty: Take a look at functions qgar::WDSegmentList::set(), and conversions from WDSegments to Segments. Find a way to remove this class!

Class qgar::WDSegmentList: The class should be a client of STL class list, instead of deriving from it!